chore: Remove redundant cast

Previously we would always assign a minimum color similarity of 1.0,
regardless of the option set. Now we set a minimum similarity according
to the option set in the configuration, otherwise the default set for
that option and fall back to a simple default value declared at the top
of the file.

.woodpecker/static_analysis.yml

@@ -3,7 +3,7 @@ steps:
     image: nikolaik/python-nodejs
     commands:
       - npm install --global pyright
-      - poetry install
+      - uv sync
-      - python --version && poetry --version && pyright --version
+      - python --version && uv version && pyright --version
       - echo "------------- running pyright typecheck -------------"
-      - poetry run pyright
+      - uv run pyright

.woodpecker/test.yml

@@ -3,9 +3,9 @@ when:
 
 steps:
   pytest:
-    image: ghcr.io/withlogicco/poetry:1.5.1
+    image: nikolaik/python-nodejs
     commands:
-      - poetry install
+      - uv sync
-      - python --version && poetry --version
+      - python --version && uv version
       - echo "------------- running pytest -------------"
-      - poetry run pytest
+      - uv run pytest

papis_extract/annotation.py

@@ -6,8 +6,7 @@ import chevron
 import papis.config
 from papis.document import Document
 
-TEXT_SIMILARITY_MINIMUM = 0.75
+COLOR_SIMILARITY_MINIMUM_FALLBACK = 0.833
-COLOR_SIMILARITY_MINIMUM = 0.833
 
 COLORS: dict[str, tuple[float, float, float]] = {
     "blue": (0, 0, 1),
@@ -38,14 +37,17 @@ class Annotation:
         page: int = 0,
         tag: str = "",
         type: str = "Highlight",
-        minimum_similarity_color: float = 1.0,
+        minimum_similarity_color: float | None = None,
     ) -> None:
-        self.minimum_similarity_color = minimum_similarity_color
         self.file = file
         self._color = color
         self.content = content
         self.note = note
         self.page = page
+        self.minimum_similarity_color = minimum_similarity_color or (
+            papis.config.getfloat("minimum_similarity_color", "plugins.extract")
+            or COLOR_SIMILARITY_MINIMUM_FALLBACK
+        )
         self.tag = tag or self._tag_from_colorname(self.colorname or "")
         self.type = type
 
@@ -85,9 +87,6 @@ class Annotation:
         """
         annot_colors = self.color or (0.0, 0.0, 0.0)
         nearest = None
-        minimum_similarity = (
-            papis.config.getfloat("minimum_similarity_color", "plugins.extract") or 1.0
-        )
         minimum_similarity = self.minimum_similarity_color
         for name, values in COLORS.items():
             similarity_ratio = self._color_similarity_ratio(values, annot_colors)

papis_extract/extractors/pdf.py

@@ -35,7 +35,6 @@ class PdfExtractor:
                 for (
                     page
                 ) in doc:  # pyright: ignore [reportUnknownVariableType] - missing stub
-                    page = cast(mu.Page, page)
                     annot: mu.Annot
                     for annot in page.annots():
                         quote, note = self._retrieve_annotation_content(page, annot)