Commit graph

5 commits

Author SHA1 Message Date
e032a5c192
refactor(code): Extract internal validity ranking keywords
Extracted keywords into dict which can be extended with either keywords
or rankings as needed, providing more flexibility.
2024-02-16 17:59:09 +01:00
4e865ee2b5
feat(code): Warn if findings studies do not match available
Since we add the studies that bring findings for the finding tables manually,
this ensures that we spot any mistakes when entering them, or similar
discrepancies on the other side of the raw data.
2024-02-16 17:58:02 +01:00
fac7d4c86a
refactor(code): Split validity calc and matrix extract
Validity calculation belongs to the modelling, so we put it into the
validity module.

Extracting our matrix is a processing step so we made its own matrix
module and put it in their.
Should hopefully provide better separation of concerns going forward.
2024-02-16 11:25:19 +01:00
8333bbe9be
refactor(code): Rename validity module
From strength of findings to the more general validity module, which can then
in turn contain the 'add_to_findings' function which unsurprisingly adds
validities to findings. Makes more sense to me.
2024-02-16 10:24:31 +01:00
953720ce54
refactor(code): Move finding table validities into model module
All findings tables can use the validities functionality to add strength of
evidence (internal/external) to themselves. Generalized the function to
work for any main findings csv (to dataframe) table not just institional
findings.
2024-02-15 16:32:46 +01:00