Restructure Rules #20

New Issue

2018-07-10T12:51:46Z

marty-oehme commented

2018-07-10 12:51:46 +00:00

(Migrated from gitlab.com)

Currently rules are only an evaluation function. This means unnecessary overhead when iterating through the grid of cells later. (iterate surviveRules, iterate birthRules) It also is not expandable to new effects (death effect, multiplication effect etc)

Therefore Rules should be buildable (through e.g. json input) to have an effect, an evaluation function and type of evaluation input (currently only neighbor count, could be history etc). Only effects should be necessary, the other two should have default implementations.

example implementation:

enum RuleEffect { Birth, Survival }
enum RuleInput { Neighbors }

class Rule {
  final Function evaluate;
  final RuleEffect effect;

  Rule(RuleEffect effect, {Function evaluate, RuleInput input, int desiredValue})
      : this.effect = effect,
        this.input = input ?? RuleInput.Neighbors,
        this.evaluate = evaluate ?? ((int input) { input == desiredValue ?? 0; }) {}
}

Currently rules are only an evaluation function. This means unnecessary overhead when iterating through the grid of cells later. (iterate surviveRules, iterate birthRules) It also is not expandable to new effects (death effect, multiplication effect etc) Therefore Rules should be buildable (through e.g. json input) to have an effect, an evaluation function and type of evaluation input (currently only neighbor count, could be history etc). Only effects should be necessary, the other two should have default implementations. example implementation: ``` dart enum RuleEffect { Birth, Survival } enum RuleInput { Neighbors } class Rule { final Function evaluate; final RuleEffect effect; Rule(RuleEffect effect, {Function evaluate, RuleInput input, int desiredValue}) : this.effect = effect, this.input = input ?? RuleInput.Neighbors, this.evaluate = evaluate ?? ((int input) { input == desiredValue ?? 0; }) {} } ```

marty-oehme commented

2018-07-10 12:52:42 +00:00

(Migrated from gitlab.com)

changed the description

marty-oehme commented

2018-08-31 07:28:22 +00:00

(Migrated from gitlab.com)

added ~7009327 and removed ~7009326 labels

marty-oehme commented

2018-10-25 15:37:44 +00:00

(Migrated from gitlab.com)

changed milestone to %4