experiments/cellular-automata
1
0
Fork 0
Code Issues 29 Pull requests Projects Releases Wiki Activity

Revert "Add getCell and setCell method to Simulation"

Browse source 
This reverts commit 52b440351d.
This commit is contained in:
Unknown 2018-10-23 20:41:54 +02:00
parent 52b440351d
commit 2e7fd7c3d3
2 changed files with 6 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/src/Simulation.dart
View file

@ -72,10 +72,6 @@ class Simulation {
return math.Point<int>(cx.toInt(), cy.toInt()); return math.Point<int>(cx.toInt(), cy.toInt());
} }
bool getCell(int x, int y) => map.get(x, y);
void setCell(int x, int y, bool value) => map.set(x, y, value);
void toggleCellState(int x, int y) { void toggleCellState(int x, int y) {
map.set(x, y, !map.get(x, y)); map.set(x, y, !map.get(x, y));
} }

32
test/simulation_test.dart
View file

@ -7,8 +7,6 @@ import 'package:test/test.dart';
class MockGrid extends Mock implements Grid<bool> {} class MockGrid extends Mock implements Grid<bool> {}
// TODO: reinstate when decoupling rendering from Simulation @Tags(const ["nobrowser"])
void main() { void main() {
Simulation sut; Simulation sut;
setUp(() { setUp(() {
@ -27,7 +25,7 @@ void main() {
var oldMap = sut.map; var oldMap = sut.map;
sut.gridSize = Point(10, 10); sut.gridSize = Point(10, 10);
expect(sut.map, isNot(same(oldMap))); expect(sut.map, isNot(same(oldMap)));
}); }, tags: "nobrowser");
}); });
group("resetMap", () { group("resetMap", () {
test("sets the internal map filled with 'false' ", () { test("sets the internal map filled with 'false' ", () {
@ -40,7 +38,7 @@ void main() {
sut.clearMap(); sut.clearMap();
expect(sut.dirty, true); expect(sut.dirty, true);
}); });
}); }, tags: "nobrowser");
group("save&load", () { group("save&load", () {
test( test(
"saves a copy of the map which does not change when the actual map changes", "saves a copy of the map which does not change when the actual map changes",
@ -51,38 +49,20 @@ void main() {
expect(sut.loadSnapshot(), isNot(equals(snapshot))); expect(sut.loadSnapshot(), isNot(equals(snapshot)));
}); });
}); }, tags: "nobrowser");
group("getCellState", () {
test("throws RangeError if outside map bounds", () {
expect(() => sut.getCell(9, 10), throwsRangeError);
});
test("returns cell value", () {
sut.map.set(1, 1, true);
expect(sut.getCell(1, 1), true);
});
});
group("setCellState", () {
test("throws RangeError if outside map bounds", () {
expect(() => sut.setCell(9, 10, true), throwsRangeError);
});
test("sets cell value", () {
sut.setCell(1, 1, true);
expect(sut.getCell(1, 1), true);
});
});
group("toggleCellState", () { group("toggleCellState", () {
test("throws RangeError if outside the map bounds", () { test("throws RangeError if outside the map bounds", () {
expect(() => sut.toggleCellState(10, 9), throwsRangeError); expect(() => sut.toggleCellState(10, 9), throwsRangeError);
}); }, tags: const ["nobrowser"]);
test("sets the cell to false if currently true", () { test("sets the cell to false if currently true", () {
sut.map.set(1, 1, true); sut.map.set(1, 1, true);
sut.toggleCellState(1, 1); sut.toggleCellState(1, 1);
expect(sut.map.get(1, 1), false); expect(sut.map.get(1, 1), false);
}); }, tags: const ["nobrowser"]);
test("sets the cell to true if currently false", () { test("sets the cell to true if currently false", () {
sut.map.set(1, 1, false); sut.map.set(1, 1, false);
sut.toggleCellState(1, 1); sut.toggleCellState(1, 1);
expect(sut.map.get(1, 1), true); expect(sut.map.get(1, 1), true);
}); }, tags: const ["nobrowser"]);
}); });
} }