fix: Correct whitespace separation on editor shell call
Switch to using 'sequence'-delineated arguments given to the subprocess run call to correctly handle whitespace. Also check the output, so we exit if we have an error. Test accordingly.
This commit is contained in:
parent
3f10b429a2
commit
762b4a288f
2 changed files with 12 additions and 1 deletions
2
topen.py
2
topen.py
|
|
@ -97,7 +97,7 @@ def get_notes_file(uuid: str, notes_dir: Path, notes_ext: str) -> Path:
|
|||
|
||||
def open_editor(file: Path, editor: str) -> None:
|
||||
"""Opens a file with the chosen editor."""
|
||||
_ = subprocess.run(f"{editor} {file}", shell=True)
|
||||
_ = subprocess.run([editor, str(file)], check=True)
|
||||
|
||||
|
||||
def is_annotation_missing(task: Task, annotation_content: str) -> bool:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue