fix: Correct whitespace separation on editor shell call

Switch to using 'sequence'-delineated arguments given to the subprocess
run call to correctly handle whitespace.
Also check the output, so we exit if we have an error.
Test accordingly.
This commit is contained in:
Marty Oehme 2025-11-29 18:28:52 +01:00
parent 84a16ee307
commit e84adc4392
Signed by: Marty
GPG key ID: 4E535BC19C61886E
2 changed files with 12 additions and 1 deletions

View file

@ -97,7 +97,7 @@ def get_notes_file(uuid: str, notes_dir: Path, notes_ext: str) -> Path:
def open_editor(file: Path, editor: str) -> None:
"""Opens a file with the chosen editor."""
_ = subprocess.run(f"{editor} {file}", shell=True)
_ = subprocess.run([editor, str(file)], check=True)
def is_annotation_missing(task: Task, annotation_content: str) -> bool: